This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add support for custom KubeClient #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
regadas
force-pushed
the
pluginentry_kubeclient
branch
from
9ca0d91 to
71567fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 59.92% 60.44% +0.52%
==========================================
Files 129 130 +1
Lines 6967 7044 +77
==========================================
+ Hits 4175 4258 +83
+ Misses 2371 2359 -12
- Partials 421 427 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
regadas
force-pushed
the
pluginentry_kubeclient
branch
2 times, most recently
from
d2c71f6 to
0e5774c
Compare
EngHabu
reviewed
Mar 5, 2021
regadas
force-pushed
the
pluginentry_kubeclient
branch
2 times, most recently
from
3774465 to
574a2fa
Compare
Signed-off-by: Filipe Regadas <[email protected]>
regadas
force-pushed
the
pluginentry_kubeclient
branch
from
574a2fa to
ca00149
Compare
kumare3
reviewed
Mar 17, 2021
| @@ -32,6 +32,14 @@ type PluginEntry struct { | |||
| // support the same task type. This must be a subset of RegisteredTaskTypes and at most one default per task type | |||
| // is supported. | |||
| DefaultForTaskTypes []pluginsCore.TaskType | |||
| // Returns a new KubeClient to be used instead of the internal controller-runtime client. | |||
| NewKubeClient func(ctx context.Context) (pluginsCore.KubeClient, error) | |||
There was a problem hiding this comment.
Should we call this - customKubeClient
|
Looks good to me, one nit |
Signed-off-by: Filipe Regadas <[email protected]>
kumare3
approved these changes
Mar 17, 2021
milton0825
pushed a commit
to milton0825/flyteplugins
that referenced
this pull request
May 25, 2021
* Add support for custom KubeClient Signed-off-by: Filipe Regadas <[email protected]> * review Signed-off-by: Filipe Regadas <[email protected]> Signed-off-by: Chao-Han Tsai <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add support for custom KubeClient Signed-off-by: Filipe Regadas <[email protected]> * review Signed-off-by: Filipe Regadas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow supplying a custom KubeClient to
PluginManager. When suppliedPluginManagershould use this client instead of the internal one.By supplying a custom
KubeClientwe are able to create a client to a remote cluster.Type
Are all requirements met?